Author Topic: File path and icon issue, incorrect path "C:\Program Files (x86)\..." (Read 39102 times)

Vanav · « **on:** August 05, 2012, 08:27 AM »

Hello.

I run FARR v.2.105.01 under Windows 7 and I have issue with file path and icons (see attached screenshot).
SecureFX and SecureCRT are both installed in "C:\Program Files\...", but first icon is correct (SecureFX on screenshot), and second icon is incorrect (SecureCRT on screenshot).
"Shell Context Menu.. - Properties" shows correct path to .exe file for both applications, "Properties.." shows incorrect path: "C:\Program Files (x86)\..." for both applications. Shortcuts in start menu are correct. FARR can launch both applications correctly. Paths in status bar are correct.

So, the issue is that second icon is incorrect (it can be either SecureCRT or SecureFX, depending on what application was launched last), and path in "Properties.." is incorrect for both applications.
How can I debug this issue?

mouser · « **Reply #1 on:** September 18, 2012, 08:27 AM »

Hi Vanav,

Sorry it's taken so long to reply. Is this problem still happening?

Can you explain a bit more what things are working incorrectly?

Vanav · « **Reply #2 on:** September 21, 2012, 02:34 PM »

I've tested v2.107.01, issue is still there. Here are screenshots. What is incorrect:
1) no icon of program, if program is in 2, 3, 4, 5 row. First row always have correct icon for this program.
2) incorrect path in "Properties..." of program.
I don't know why there is incorrect path.

mouser · « **Reply #3 on:** September 21, 2012, 04:18 PM »

If you go to your Launch History tab, is the wrong path for these items in the launch history?

If you right-click and clear all entries, are the icons now all correct when you search?

If so, does launching one of the items subsequently make the icon break again?

Vanav · « **Reply #4 on:** September 21, 2012, 04:38 PM »

1. Path is correct, but it is path to shortcut: "C:\ProgramData\Microsoft\Windows\Start Menu\Programs\SecureCRT 7.1\SecureCRT 7.1.lnk"
2. Icons for this applications for second row and below are still not correct with empty history.

So, path to shortcut is always correct. But path to application is sometimes incorrect. I think, this is the reason for missing icon.

If I check shortcut properties ("C:\ProgramData\Microsoft\Windows\Start Menu\Programs\SecureCRT 7.1\SecureCRT 7.1.lnk"), path is correct there.

mouser · « **Reply #5 on:** September 21, 2012, 05:28 PM »

Can you tell me what you have for these two settings, and if changing them makes a difference:
Screenshot - 9_21_2012 , 5_26_31 PM.png

I need to be able to figure out how to reproduce this problem as this program files x86 workaround code i have in place is a total mess of confusion that i don't understand.. and if i can't reproduce it i stand no hope of fixing it except by accident.

So if you can find any clues as to why this bug is triggering in some cases and not others and what it is about these shortcuts that is causing it, please let me know.

mouser · « **Reply #6 on:** September 21, 2012, 05:50 PM »

ok i think i may have a clue:

i wonder if the problem isnt because of the . in the shortcut file name.

Can you try this for me,
make a copy of your securefx shortcuts, and confirm the problem remains with them.
now rename your shortcut copies but without any . periods in the name before the .lnk and see if the problem is fixed for these shortcut copies with no . in their names.

Vanav · « **Reply #7 on:** September 21, 2012, 06:17 PM »

All this doesn't help. But seems I've found the issue.

If I take a look in hex contents of shortcut, it has this string: "..\..\..\..\..\..\Program Files\VanDyke Software\Clients\SecureCRT.exe". Author of shortcut decided not to hardcode drive letter, but walk to the root.

If I visit folder "C:\ProgramData\Microsoft\Windows\Start Menu\Programs\SecureCRT 7.1\" with 64-bit application (Explorer), short is resolved correctly.

If I visit the same folder with 32-bit application (say, Firefox - New Tab - Open File...), then shortcut is resolved incorrectly, and icon is missing.

So, seems system resolver is confused with such relative path, and substitutes "Program Files" depending on current environment, x86 or not. I don't know, it is a bug or a feature.

Update. Shortcut is attached. All this beauty is under Windows 7 x64.

mouser · « **Reply #8 on:** September 21, 2012, 06:26 PM »

great work.

ok so it looks like it's a crazy shortcut.

is it the case that the only shortcuts with this problem on your pc that you know of are those from vandyke?

or is this a more common crazyness?

Vanav · « **Reply #9 on:** September 22, 2012, 03:52 PM »

Applications with the same issue:
- 7-Zip
- COMODO Internet Security (icon is correct, path is not correct)
- Far Manager 2 x64
- Microsoft Mathematics
- TortoiseSVN
- All games here: C:\ProgramData\Microsoft\Windows\Start Menu\Programs\Games
Say, if I search for "minesweeper", icon is broken, and game even can't launch.
- All shortcuts here: C:\ProgramData\Microsoft\Windows\Start Menu\Programs\Maintenance
- Part of shortcuts here: C:\ProgramData\Microsoft\Windows\Start Menu\Programs\Accessories

Let's take a closer look at .lnk contents of "bad" link using link parser [1] or [2]. Not relevant fields are excluded.

[Select]

[Filename]: C:\ProgramData\Microsoft\Windows\Start Menu\Programs\SecureFX 7.1\SecureFX 7.1.lnk

[Header]
Icon index: 0
ShowWindow value: 1 (SW_SHOWNORMAL / SW_NORMAL)
Hot key value: 0x0000 (None)
Link flags: 0x0000008b (HasLinkTargetIDList, HasLinkInfo, HasRelativePath, IsUnicode)

[Link Target ID List]
...
[Link Info]
Location flags: 0x00000001 (VolumeIDAndLocalBasePath)
Drive type: 3 (DRIVE_FIXED)
Drive serial number: 368f-2269
Volume label (ASCII): MainSDD
Local path (ASCII): C:\Program Files\VanDyke Software\Clients\SecureFX.exe

[String Data]
Relative path (UNICODE): ..\..\..\..\..\..\Program Files\VanDyke Software\Clients\SecureFX.exe

[Known Folder Location]
Known folder GUID: 905e63b6-c1bf-494e-b29c-65b732d3d21a = ProgramFiles
First child segment offset: 141 bytes

[Metadata Property Store]
Property set GUID: 46588ae2-4cbc-4338-bbfc-139326986dce
ID: 4
Value: 0x001f (VT_LPWSTR) S-1-5-18

[Special Folder Location]
Special folder identifier: 38 (ProgramFiles)
First child segment offset: 141 bytes

Special folder "ProgramFiles" is specified for link. But this variable has different meaning depending on 32- or 64-bit application [3]. On 64-bit OS in 64-bit application FOLDERID_ProgramFiles= %SystemDrive%\Program Files, but in 32-bit application FOLDERID_ProgramFiles = %SystemDrive%\Program Files (x86). That's why link resolves incorrectly in FARR and in any other 32-bit file explorer.

Need to remove KNOWNFOLDERID from shortcut to fix the link. (Also specifying "ProgramFilesX86" will make link correct for uncertain reason).

If you want to get correct icon and path, it is possible. You should ignore Special Folder section, and use just other Icon and Path sections. Here is example of minimal correct link to 64-bit application:

[Select]

[Filename]: C:\ProgramData\Microsoft\Windows\Start Menu\Programs\Vovoid VSXu\VSXu Player.lnk

[Header]
Date created: Unknown
Last accessed: Unknown
Last modified: Unknown
File size: 0 bytes
File attributes: 0x00000000 (None)
Icon index: 0
ShowWindow value: 1 (SW_SHOWNORMAL / SW_NORMAL)
Hot key value: 0x0000 (None)
Link flags: 0x00000099 (HasLinkTargetIDList, HasRelativePath, HasWorkingDir, IsUnicode)

[Link Target ID List]
CLSID: 20d04fe0-3aea-1069-a2d8-08002b30309d = My Computer

Drive: C:\

Folder attributes: 0x00000010 (FILE_ATTRIBUTE_DIRECTORY)
Short directory name: Program Files
Long directory name: Program Files

Folder attributes: 0x00000010 (FILE_ATTRIBUTE_DIRECTORY)
Short directory name: Vovoid VSXu
Long directory name: Vovoid VSXu

File size: 0 bytes
File attributes: 0x00000000 (None)
8.3 filename: vsxu_player.exe
Long filename: vsxu_player.exe

[String Data]
Relative path (UNICODE): ..\..\..\..\..\..\Program Files\Vovoid VSXu\vsxu_player.exe
Working Directory (UNICODE): C:\Program Files\Vovoid VSXu

[Metadata Property Store]
Property set GUID: 46588ae2-4cbc-4338-bbfc-139326986dce

You can use "Link Target ID" or "Relative path" to find path to executable, and use "Icon Location" and "Icon Index" section for icon. More about lnk file format is in PDF documents [4].

Shortcuts to games from Game Manager fail for different reason. But if you want to support games too, it is possible. Take a look in .lnk and find magic id "GFSI". Next 16 bytes is GUID of game in Game Explorer in little-endian form. Example:

[Select]

0000000060: 0D 52 20 00 00 00 47 46 │ 53 49 C0 79 15 E9 A9 4E ♪R GFSIАy§й©N
0000000070: 2A 4A A9 B2 04 BE F1 D6 │ DC 29 00 00 00 00 00 00 *J©І♦ѕсЦЬ)

Hex is: C0 79 15 E9...
GUID is E91579C0-4EA9-4a2a-A9B2-04BEF1D6DC29
All details (path, icon, etc) can be found here:
HKEY_LOCAL_MACHINE\SOFTWARE\Microsoft\Windows\CurrentVersion\GameUX\Games\{E91579C0-4EA9-4a2a-A9B2-04BEF1D6DC29}
More about this format is in lnk specification [5].

Game Manager is used not only for standard games, but also for third party games like StarCraft II Wings of Liberty™.lnk etc, that's why support of games shortcuts is important. Maybe there is some API to get link informations for games.

Some shortcuts in C:\ProgramData\Microsoft\Windows\Start Menu\Programs\Maintenance or ...\Accessories don't work, because they link to files like %systemroot%\system32\recdisc.exe, but in 32-bit application %systemroot%\system32 is replaced by %systemroot%\SysWOW64, and target applications are not there. You can fix this at link resolving time.

[1] LNK Parser - http://code.google.c...arser/downloads/list
[2] Windows LNK Parsing Utility - http://www.tzworks.n...page.php?proto_id=11
[3] KNOWNFOLDERID (bottom of page) http://msdn.microsof...57%28v=vs.85%29.aspx
[4] liblnk library and documentation - http://code.google.c...iblnk/downloads/list
[5] Windows Shell Item format - http://liblnk.google...%20Item%20format.pdf

Other used references:
- Quick overview of Lnk File Format and Ways of Information Extraction - https://www.evernote...663f/wishi/crazylazy
- LNK format - http://www.forensicswiki.org/wiki/LNK
- LNK Parsing: You’re doing it wrong (I, II) - http://blog.0x010000...re-doing-it-wrong-i/ , http://blog.0x010000...e-doing-it-wrong-ii/
- Evidentiary Value of Link Files | ForensicFocus.com - http://www.forensicf...le-evidentiary-value

mouser · « **Reply #10 on:** September 22, 2012, 09:05 PM »

Vanav, can you verify the problem still exists with the latest FARR beta?

Vanav · « **Reply #11 on:** September 29, 2012, 07:58 AM »

I'm sorry for a delay.

Issues with icons for shortcuts that incorrectly use "Special Folder" is fixed in v2.200.01.

Issues with shortcuts here:
- C:\ProgramData\Microsoft\Windows\Start Menu\Programs\Games
- C:\ProgramData\Microsoft\Windows\Start Menu\Programs\Maintenance
- C:\ProgramData\Microsoft\Windows\Start Menu\Programs\Accessories
are not fixed, but this gives no much trouble for me currently.

Thank you.

mouser · « **Reply #12 on:** September 29, 2012, 08:11 AM »

Well that's excellent news!

When you get a chance if you could see if you can figure out any clues about why those shortcuts in "C:\ProgramData\Microsoft\Windows\Start Menu\Programs\Games" aren't working properly.. I wonder if it's related to the issue described here.

Vanav · « **Reply #13 on:** October 02, 2012, 10:10 AM »

I've found a regression. This shortcut has incorrect icon:

[Select]

[Filename]: C:\ProgramData\Microsoft\Windows\Start Menu\Programs\Cisco Systems VPN Client\VPN Client.lnk

[Header]
Date created: Unknown
Last accessed: Unknown
Last modified: Unknown
File size: 0 bytes
File attributes: 0x00000000 (None)
Icon index: 1
ShowWindow value: 1 (SW_SHOWNORMAL / SW_NORMAL)
Hot key value: 0x0000 (None)
Link flags: 0x000050dd (HasLinkTargetIDList, HasName, HasRelativePath, HasWorkingDir, HasIconLocation, IsUnicode, HasDarwinID, HasExpIcon)

[Link Target ID List]
CLSID: 20d04fe0-3aea-1069-a2d8-08002b30309d = My Computer

Drive: C:\

Last modified: 10/10/2011 (11:55:02.0) [UTC]
Folder attributes: 0x00000010 (FILE_ATTRIBUTE_DIRECTORY)
Short directory name: Windows
Date created: 07/14/2009 (03:20:10.0) [UTC]
Last accessed: 10/10/2011 (11:55:02.0) [UTC]
Long directory name: Windows

Last modified: 10/10/2011 (11:56:24.0) [UTC]
Folder attributes: 0x00000016 (FILE_ATTRIBUTE_HIDDEN, FILE_ATTRIBUTE_SYSTEM, FILE_ATTRIBUTE_DIRECTORY)
Short directory name: INSTAL~1
Date created: 04/22/2010 (15:51:06.0) [UTC]
Last accessed: 10/10/2011 (11:56:24.0) [UTC]
Long directory name: Installer

Last modified: 10/05/2011 (19:04:46.0) [UTC]
Folder attributes: 0x00000010 (FILE_ATTRIBUTE_DIRECTORY)
Short directory name: {5FDC0~1
Date created: 10/05/2011 (19:04:46.0) [UTC]
Last accessed: 10/05/2011 (19:04:46.0) [UTC]
Long directory name: {5FDC06BF-3D3D-4367-8FFB-4FAFCB61972D}

File size: 5120 bytes
Last modified: 10/05/2011 (19:04:46.0) [UTC]
File attributes: 0x00000021 (FILE_ATTRIBUTE_READONLY, FILE_ATTRIBUTE_ARCHIVE)
8.3 filename: ICON09~1.EXE
Date created: 10/05/2011 (19:04:46.0) [UTC]
Last accessed: 10/05/2011 (19:04:46.0) [UTC]
Long filename: Icon09DB8A85.exe

[String Data]
Comment (UNICODE): Cisco Systems Inc. VPN Client
Relative path (UNICODE): ..\..\..\..\..\..\Windows\Installer\{5FDC06BF-3D3D-4367-8FFB-4FAFCB61972D}\Icon09DB8A85.exe
Working Directory (UNICODE): C:\Program Files (x86)\Cisco Systems\VPN Client\
Icon location (UNICODE): C:\windows\Installer\{5FDC06BF-3D3D-4367-8FFB-4FAFCB61972D}\Icon09DB8A85.exe

[Darwin Properties]
Application identifier (ASCII): %sjmFMWHa9^'EEapvR`2Complete>ZS@)2jIL4@Bl}5](Qg_z
Application identifier (UNICODE): %sjmFMWHa9^'EEapvR`2Complete>ZS@)2jIL4@Bl}5](Qg_z

[Icon Location]
Icon location (ASCII): %SystemRoot%\Installer\{5FDC06BF-3D3D-4367-8FFB-4FAFCB61972D}\Icon09DB8A85.exe
Icon location (UNICODE): %SystemRoot%\Installer\{5FDC06BF-3D3D-4367-8FFB-4FAFCB61972D}\Icon09DB8A85.exe

Notice "Icon index" and "Icon location (UNICODE)".
You show icon with index 0 from Icon09DB8A85.exe, but you should show icon with index 1.
As far as I remember, previous version had no such bug.

Update. About issue https://www.donation....msg301518#msg301518
Seems you ignore icon of shortcut. I've make a shortcut and assigned standard icon to it (from shell32.dll), as most users will do. Here is shortcut properties:

[Select]

[Filename]: C:\Users\Ivan\Desktop\WebServer Stop.lnk

[Header]
Date created: 05/28/2012 (09:21:07.64) [UTC]
Last accessed: 05/28/2012 (09:21:07.64) [UTC]
Last modified: 05/28/2012 (09:27:34.758) [UTC]
File size: 47 bytes
File attributes: 0x00000020 (FILE_ATTRIBUTE_ARCHIVE)
Icon index: 27
ShowWindow value: 1 (SW_SHOWNORMAL / SW_NORMAL)
Hot key value: 0x0000 (None)
Link flags: 0x000800db (HasLinkTargetIDList, HasLinkInfo, HasRelativePath, HasWorkingDir, HasIconLocation, IsUnicode, EnableTargetMetadata)

[Link Target ID List]
CLSID: 20d04fe0-3aea-1069-a2d8-08002b30309d = My Computer

Drive: C:\

Folder attributes: 0x00000010 (FILE_ATTRIBUTE_DIRECTORY)
Short directory name: Utils
Long directory name: Utils

File size: 47 bytes
Last modified: 05/28/2012 (09:27:36.0) [UTC]
File attributes: 0x00000020 (FILE_ATTRIBUTE_ARCHIVE)
8.3 filename: WEBSER~2.BAT
Date created: 05/28/2012 (09:21:08.0) [UTC]
Last accessed: 05/28/2012 (09:21:08.0) [UTC]
Long filename: WebServerStop.bat

[Link Info]
Location flags: 0x00000001 (VolumeIDAndLocalBasePath)
Drive type: 3 (DRIVE_FIXED)
Drive serial number: 368f-2269
Volume label (ASCII): MainSDD
Local path (ASCII): C:\Utils\WebServerStop.bat

[String Data]
Relative path (UNICODE): ..\..\..\Utils\WebServerStop.bat
Working Directory (UNICODE): C:\Utils
Icon location (UNICODE): %SystemRoot%\system32\SHELL32.dll

[Metadata Property Store]
Property set GUID: b725f130-47ef-101a-a5f1-02608c9eebac
ID: System.ItemTypeText
Value: 0x001f (VT_LPWSTR) WebServerStop.bat
ID: System.ItemTypeText
Value: 0x001f (VT_LPWSTR) ???????? ???? Windows
ID: System.DateCreated
Value: 0x0040 (VT_FILETIME) 05/28/2012 (09:21:08.0) [UTC]
ID: System.Size
Value: 0x0015 (VT_UI8) 0x000000000000002f = 47
ID: System.DateModified
Value: 0x0040 (VT_FILETIME) 05/28/2012 (09:27:36.0) [UTC]

Property set GUID: dabd30ed-0043-4789-a7f8-d013a4736622
ID: System.ItemFolderPathDisplayNarrow
Value: 0x001f (VT_LPWSTR) Utils (C:)

Property set GUID: 28636aa6-953d-11d2-b5d6-00c04fd918d0
ID: System.ParsingPath
Value: 0x001f (VT_LPWSTR) C:\Utils\WebServerStop.bat

[Distributed Link Tracker Properties]
Version: 0
NetBIOS name: ivan-hp
Droid volume identifier: cce0ad80-af66-4a74-bb97-9a2afa1ba305
Droid file identifier: 77c006aa-a3d0-11e1-ae15-c35a2998b499
Birth droid volume identifier: cce0ad80-af66-4a74-bb97-9a2afa1ba305
Birth droid file identifier: 77c006aa-a3d0-11e1-ae15-c35a2998b499
MAC address: c3:5a:29:98:b4:99
UUID timestamp: 05/22/2012 (05:39:15.542) [UTC]
UUID sequence number: 11797

Notice "Icon index" and "Icon location (UNICODE)".

mouser · « **Reply #14 on:** October 02, 2012, 12:45 PM »

Yes, i think i can fix this.

xjamms · « **Reply #15 on:** October 09, 2012, 06:58 AM »

I have been having problems with icons displaying and I think it is the same problem. I will wait for a fix to come out and retest.

mouser · « **Reply #16 on:** October 14, 2012, 03:18 PM »

Can you guys try the new beta (2.203) and let me know if it fixes the icon problem (or makes it worse):
https://www.donation...AndRunRobotSetup.exe

Vanav · « **Reply #17 on:** October 15, 2012, 05:35 AM »

Custom icon is fixed and icon index is used now. But issue with a lot of broken icons of 64-bit applications with specified "known folder" is back. "Intel TurboBoost" is one more example of such application.

mouser · « **Reply #18 on:** October 15, 2012, 09:28 AM »

That's what I was afraid of, ok one last idea to try.

mouser · « **Reply #19 on:** October 15, 2012, 10:01 AM »

Re-uploaded new version at same url, let's see if this one is a good compromise.

First private report from Vanav are that the new one is looking good!

d4ni · « **Reply #20 on:** October 16, 2012, 05:43 AM »

The newest version still works fine with my custom system power icons.

xjamms · « **Reply #21 on:** October 16, 2012, 02:06 PM »

I am still having problems with Icons displaying. I think the problem I am having may be different though. Here are some of the symptoms I am seeing
1) Folders - instead of showing the folder icon, it shows the icon for IcoFX.
2) Plugins - icons for plugins are not displaying. Also showing IcoFX icon. For example, if using HNote, when the icons displayed on the FARR status bar are IcoFX icons instead of correct hnote icons.
3) This is also occurring with some of the aliases I setup. Most resolve the correct icon for the lnk, but others do not.
4) Also when I open DCUpdater the icons for the plugins (like hnote, Fcalc aren't displayed, same icofx icon).

I have a couple of unsupported hunches that I am going to try to check into
- Maybe setting IcoFX as the default viewer for .ico files caused some conflict
- Or I changed the 'default file icon' to this icon by mistake at some point.
- Looking through the registry for anything irregular as well.

If I don't find anything through there I'll see if Link Parser or any of the other links from Vanav help. I debug / reproduce bugs for software as part of my job, figuring this stuff out is how I slack off...

mouser · « **Reply #22 on:** October 16, 2012, 02:20 PM »

Also when I open DCUpdater the icons for the plugins (like hnote, Fcalc aren't displayed, same icofx icon).

this is a big clue that the problem is not in FARR itself but in some system icon problem.. maybe rebuilding icon cache will fix it?

xjamms · « **Reply #23 on:** October 16, 2012, 03:06 PM »

Also when I open DCUpdater the icons for the plugins (like hnote, Fcalc aren't displayed, same icofx icon).

this is a big clue that the problem is not in FARR itself but in some system icon problem.. maybe rebuilding icon cache will fix it?
-mouser (October 16, 2012, 02:20 PM)

Rebuilding the Icon Cache corrected the problem in DCUpdater, but not in FARR.
FARR is still showing icoFX icon for icons when I type "hnote" in search box and for folder icons. (and some aliases that probably are using unknown icon or default file icon).

xjamms · « **Reply #24 on:** October 16, 2012, 03:21 PM »

Icons are now working again.
After rebuilding the icon cache, I rebooted and icons were still not correct.
I then reset the default applications and default icons for .ico, folders, and directory - and rebooted again.
Now it is working.