Author Topic: DC SMF Search Mod - an improvement search for smf forum (codename Zillarank) (Read 88010 times)

mouser · « **Reply #25 on:** July 10, 2007, 02:52 PM »

Here's the description by smf of their licensing choices, which always seemed pretty reasonable to me, and it's why i never worried about this issue:
http://www.simplemac...about/opensource.php

I can understand their expressed desires and don't have a problem with them.

Wordzilla · « **Reply #26 on:** July 10, 2007, 03:09 PM »

Philosophy is philosophy, a good read it may be; terms are terms, that we have to abide by.

Read: Microsoft and Open Source

I dont see any part of the above SMF and Open Source write-up that cannot be justified with "we're closing source and charging for it because only experts are coding it and there's no fork to confuse users -- a win-win situation".

tinjaw · « **Reply #27 on:** July 10, 2007, 03:22 PM »

I AN NOT A LAWYER blah, blah, blah

Wordzilla,

Whenever I try to explain something like this, it always seem to come out as criticism, so I apologize as it is not intended to be such. However, since there are many readers of DonationCoder.com that may be new to these types of legal issues, I just wanted to mention that you should not have any problem with the code being copyrighted, per se. Even software from FSF, Apache, etc. is copyrighted. The copyright shows ownership, and the license tells you how you can use it. Without copyright, you have no ownership, and without ownership nobody would have to right to license the code. So, even if you write code yourself, you would not be able to put a license on it, not be able to tell people how they could use is it, nor could you tell them how they could not use it, *unless you claimed it as yours via copyright*. (Which under US law you can do to anything you create by simply affixing the copyright logo and/or the words copyright year whoever. If it is important enough, you should consult a lawyer after that. Because that is just the first step. There are more if you want it to be enforceable.)

So 1) always copyright what you write (as you can always release it to the public domain later, but it doesn't work the other way around.) 2) If you want it to stick in court, consult a lawyer.

Then, after you claim ownership, you can license it to others, for example, under the GPL v3, or the Apache license, or BSD, or any of the other gazillian licenses out there.

I am not an expert. There is a great deal more material out there on the Net and elsewhere, so if anybody is interested they should read further.

I just didn't want some of the people new to the issues at hand here to start out with a skewed concept that all copyright is evil.

jgpaiva · « **Reply #28 on:** July 10, 2007, 03:32 PM »

So I'm saying it pays to study smf alternatives like phpbb3 (I'll try) and design our site components to be less reliant on SMF forum software.
-Wordzilla (July 10, 2007, 02:38 PM)

Even though i do agree with what you're saying, i'm very sorry to hear it.
SMF forum software is miles away from any forum software i've used, and this means that a change would be a huge step backwards.

I have a doubt: are smf updates that important?
I mean, if they go payware, aren't we allowed to keep using an older version? And if we would do that, would we miss out on anything important?
From what i can see, if they don't even update their crappy search, i don't think we need them at all.

mouser · « **Reply #29 on:** July 10, 2007, 03:43 PM »

Speaking just for myself:

I like smf.
We have donated to smf repeatedly.
I do not have a problem with paying for smf if they go to a pay model that is reasonable.

My concerns in this case are not about paying for stuff - i'm just objecting to what i perceive as an inappropriate attitude and approach from smf management, which i fear may be a sign of them moving in wrong direction in terms of management and maintenance.

Having said that, i agree with wordzilla that it is unwise to be so dependent on software that could overnight move to a license that would make it unusable. But i think jgp's point is also valid -- we could always just stick with our current version if they did that.

Wordzilla · « **Reply #30 on:** July 10, 2007, 03:52 PM »

I am not an expert. There is a great deal more material out there on the Net and elsewhere, so if anybody is interested they should read further.
I just didn't want some of the people new to the issues at hand here to start out with a skewed concept that all copyright is evil.

Thx tinjaw, that makes up for my lackluster business law class

Wordzilla · « **Reply #31 on:** July 10, 2007, 04:02 PM »

Yes I have no problem with SMF and I dont doubt it's the best forum software on the planet...so far.

I guess I'm just not a fan of meritocracy/elitism, which is SMF dev about, IMO.

cranioscopical · « **Reply #32 on:** July 10, 2007, 09:40 PM »

A reply i posted which addresses some of the "why" issues that cranioscopical suggested i tackle...

and

My concerns in this case are not about paying for stuff - i'm just objecting to what i perceive as an inappropriate attitude and approach from smf management, which i fear may be a sign of them moving in wrong direction in terms of management and maintenance.

A lot of heat's been generated by a rude and ungrateful response from SMF. 'Un-words' abound for such behaviour, without a doubt; unintelligent, uncouth, uncooperative, unimaginative...

Even so,
Are you sure that, had you first sought a written permission it would not have been granted?
And are you sure that nobody in the SMF hierarchy is both senior enough to waive the requirement and intelligent enough to see the advantage in what you offer?

Anyway, many thanks -- again -- to you and Wordzilla for the very significant inprovements to the search function here. Boy, what a difference!

spottedhog · « **Reply #33 on:** July 19, 2007, 08:29 PM »

Hi,

I was "playing" online and came across your site. With great interest I read this thread. I have had similar experiences with SMF, however, I do understand their position.

Firstly, not to offend anyone here, but I think both sides are overreacting. SMF's policy is showing, especially after the recent Joomla nonsense. But SMF has been firm and never swayed in their position, since forever. This is their way of keeping control and quality. It is just the way it is.

All SMF is saying is you must have permission to distribute their code. Will they give you permission? Very highly unlikely.... Do they give you the tools and support to be able to make modifications to their code? A resounding YES!

Do I like the idea of the package installer? Not really.... pain in the butt versus straight file replacement. However, using the package installer has benefits if other Mods had change a specific file.

Actually you have 2 choices here in distributing changes to their code.
1. Is to somehow get the uninstall to work, and I feel confident someone on SMF could help.
2. List the file modifications on your site here noting how to make changes. In theory, you could list the entire file contents in a forum board where people can copy it and use it, as long as you do not remove the Copyright.

At this link:
http://www.simplemac...about/opensource.php
...there is a largely displayed, highlighted line that says:

You can modify the source code, distribute instructions to modify it, you can view the code and suggest improvements to it.

I have not seen nor used any of your SMF Mods, and right now I cannot see any of them. I was hoping I could see them, hence, why I am here. If you cannot get the package manager to properly uninstall, again, you could ask on SMF what to do, or you could maybe create a new board here, where only postings or comments could be made by the Mod developers. Then the Mod developer could list the code, or sections of modified code. Then members/visitors here could copy/paste the modifications.

.....just a thought.

Wordzilla · « **Reply #34 on:** August 06, 2007, 07:07 AM »

OK guys, feel free to try latest mod 1.1.0.0 (uploaded)

Works with SMF 1.1.3

TjaMe · « **Reply #35 on:** August 07, 2007, 09:25 AM »

Thanks a million 'zilla, your search mod is awesome!

I was trying to improve on the standard search myself, but got lost somewhere in between regexps & sql statements... I'm well impressed with what you've done in such a short period of time! More than well impressed, actually!

I just couldn't resist modifying some of your code: I changed the following:

Code: PHP [Select]

if (!isset($search_params['match_mode']))
                $search_params['match_mode'] = empty($_REQUEST['match_mode']) ? 'smart' : $_REQUEST['match_mode'];
                
        if (!empty($search_params['match_mode']))
                {
                        switch ($search_params['match_mode']) {
                        case 'whole':
                            break;
                        case 'smart':
                            break;
                        case 'any':
                            break;
                        default:
                                $search_params['match_mode'] = 'smart';
                            break;
                        }
                }
        else
                $search_params['match_mode'] = 'smart';

to:

Code: PHP [Select]

if (!isset($search_params['match_mode']))
                $search_params['match_mode'] = $_REQUEST['match_mode'];
                
        switch ($search_params['match_mode']) {
                case 'whole':
                case 'smart':
                case 'any':
                        break;
                default:
                        $search_params['match_mode'] = 'smart';
        }

then copied it to PlusSearch1. It took me a while to notice that $context['search_params']['match_mode'] != $search_params['match_mode']

... maybe I should have resisted the temptation...

Thanks again for such a superb search engine. I seriously hope all the smf community try out your mod and realize what they've been missing all these years.

Credit where it's due. Wordzilla, you're a scholar & a gentleman, and I salute you, sir!

Wordzilla · « **Reply #36 on:** August 07, 2007, 10:50 AM »

Code: PHP [Select]

if (!isset($search_params['match_mode']))
                $search_params['match_mode'] = $_REQUEST['match_mode'];
                
        switch ($search_params['match_mode']) {
                case 'whole':
                case 'smart':
                case 'any':
                        break;
                default:
                        $search_params['match_mode'] = 'smart';
        }

Your code does look v neat, thanks for sharing.

I have a question, thou:

What if $_REQUEST['match_mode'] isn't set (undefined index) before usage? Doesn't it generate a warning in forum log?

Code: PHP [Select]

if (!isset($search_params['match_mode']))
                $search_params['match_mode'] = $_REQUEST['match_mode'];

I'm so happy it's working for you TjaMe!

Care to post us the url to your forum here?

TjaMe · « **Reply #37 on:** August 08, 2007, 09:29 AM »

Ooops!

You're absolutely right about the warning on the forum log!

I was in 'trim lines mode' & got carried away...

$:-\$ I suppose that

Code: PHP [Select]

if (!isset($search_params['match_mode']))
    $search_params['match_mode'] = empty($_REQUEST['match_mode']) ? '' : $_REQUEST['match_mode'];

is the smallest that snippet can ever get without generating a warning.

Drats!

Our forum is behind a firewall on an intranet & deals with very, very boring stuff, but if we ever have a public side to it I'll post the url, I promise!

Thank you again for sharing your really excellent code!

Wordzilla · « **Reply #38 on:** August 11, 2007, 02:37 AM »

Just uploaded the latest mod 1.1.1

Cleaned up code. Minor bug fixes. Added no single character search. Thanks to Aaron: http://custom.simple...ds/index.php?mod=884

Folks at SMF carefully reviewed the mod and offered me some constructive ideas yesterday, now the new mod is in better compliance with SMF coding guidelines. Hopefully it will be officially approved by SMF very soon.

To upgrade from an earlier version:
   1. go to the package manager and UNINSTALL previous version
   2. Upload new package zip
   3. install new version

cranioscopical · « **Reply #39 on:** August 11, 2007, 11:14 AM »

Folks at SMF carefully reviewed the mod and offered me some constructive ideas yesterday, now the new mod is in better compliance with SMF coding guidelines. Hopefully it will be officially approved by SMF very soon.

A glimmer of intelligence at the end of the tunnel?

Wordzilla · « **Reply #40 on:** August 12, 2007, 05:00 PM »

Yay, finally it's approved by SMF!

http://custom.simple...ds/index.php?mod=887

cranioscopical · « **Reply #41 on:** August 12, 2007, 07:08 PM »

Yay, finally it's approved by SMF!

Congratulations! Both you and Mouser deserve credit for seeing this through.
Frankly, I don't much care about the SMF community as long as I benefit from your hard work.

It is nice to share, though, and very much in keeping with the philosophy round here.

mouser · « **Reply #42 on:** August 12, 2007, 07:10 PM »

wordzilla is a true gentleman, he really worked hard to get it in shape so others could benefit from it.

iphigenie · « **Reply #43 on:** August 14, 2007, 06:38 PM »

ironically, i tried installing the package and it detects a conflict (probably with tinyportal)

$:-\$

Wordzilla · « **Reply #44 on:** August 14, 2007, 06:41 PM »

Most likely. If possible send me a copy of your Sources/Search.php and I'll have a look.

MatthewSchenker · « **Reply #45 on:** December 17, 2007, 05:27 PM »

Does this modification work with 1.1.4? I tried to install it but got errors, including a message that it not compatible with this version of SMF.
I realy like the work you have done and want to keep using this modification on my 1.1.4 site.
Thanks!

Wordzilla · « **Reply #46 on:** December 17, 2007, 10:27 PM »

Does this modification work with 1.1.4?
-MatthewSchenker (December 17, 2007, 05:27 PM)

Yes it's tested to work with SMF 1.1.4. What error messages did you get (exactly)?

MatthewSchenker · « **Reply #47 on:** December 18, 2007, 09:11 AM »

I think it was my fault. After installing this modification, my entire site crashed. But I have a feeling it was because I changed something in the post.template.php or index.template.php file. I reinstalled my forum software, then reinstalled the search modification, and everything is working fine now.
Thanks for all the great work!!

Eddy Matthews · « **Reply #48 on:** February 22, 2008, 03:39 AM »

Would it be possible to modify DCSMFSearch so that it also searches for attached files?

At the moment there is no way to search for any attached filenames etc, and it would be a great addition if it could be done?

Many thanks
Eddy

spismf · « **Reply #49 on:** November 12, 2008, 10:43 AM »

Hi there,

Im a BIG fan of this search mod and have been using it for slightly over 7 months. now that 1.1.6 is out any chance you can upload an update? and will we have this awesome mod for 2.0?

-Jeff